Correct path of default log4j configures #12069
Conversation
|
Any instruction to add labels? If it's necessary. Thanks. |
| @@ -112,7 +112,7 @@ controller: | |||
|
|
|||
| jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log" | |||
|
|
|||
| log4j2ConfFile: /opt/pinot/etc/config/pinot-controller-log4j2.xml | |||
| log4j2ConfFile: /opt/pinot/etc/conf/pinot-controller-log4j2.xml | |||
There was a problem hiding this comment.
which configuration stated it should be conf instead of config ?
There was a problem hiding this comment.
nvm i think it is from
pinot/docker/images/pinot/Dockerfile
Line 45 in 99d34e0
There was a problem hiding this comment.
here is config located in image I found
https://github.com/apache/pinot/tree/master/docker/images/pinot/etc/conf
There was a problem hiding this comment.
I guess the configuration for conf path is from here
https://github.com/apache/pinot/blob/master/pinot-distribution/pinot-assembly.xml#L243
| @@ -112,7 +112,7 @@ controller: | |||
|
|
|||
| jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log" | |||
|
|
|||
| log4j2ConfFile: /opt/pinot/etc/config/pinot-controller-log4j2.xml | |||
| log4j2ConfFile: /opt/pinot/etc/conf/pinot-controller-log4j2.xml | |||
There was a problem hiding this comment.
nvm i think it is from
pinot/docker/images/pinot/Dockerfile
Line 45 in 99d34e0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12069 +/- ##
=============================================
+ Coverage 0.00% 61.61% +61.61%
- Complexity 6 1152 +1146
=============================================
Files 2314 2390 +76
Lines 126078 129824 +3746
Branches 19524 20082 +558
=============================================
+ Hits 6 79994 +79988
+ Misses 126072 44004 -82068
- Partials 0 5826 +5826
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is to correct default configure path for log4j in helm chart.