Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky PinotTenantRestletResourceTest #12019

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Nov 17, 2023

Another attempt of fixing #11329

Do not add fake instances which connect to the cluster, but only add instance configs. They serve the same way for testing purpose, but fake instances can cause side effect on other tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ab9e62) 61.63% compared to head (cd18c72) 34.92%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12019       +/-   ##
=============================================
- Coverage     61.63%   34.92%   -26.72%     
=============================================
  Files          2385     2309       -76     
  Lines        129271   125576     -3695     
  Branches      20016    19464      -552     
=============================================
- Hits          79682    43854    -35828     
- Misses        43792    78598    +34806     
+ Partials       5797     3124     -2673     
Flag Coverage Δ
custom-integration1 ?
integration 0.00% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 ?
java-21 34.92% <100.00%> (-26.59%) ⬇️
skip-bytebuffers-false ?
skip-bytebuffers-true 34.92% <100.00%> (-26.56%) ⬇️
temurin 34.92% <100.00%> (-26.72%) ⬇️
unittests 46.78% <100.00%> (-14.86%) ⬇️
unittests1 46.78% <100.00%> (-0.21%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang marked this pull request as ready for review November 17, 2023 19:52
@Jackie-Jiang Jackie-Jiang merged commit 8c604f8 into apache:master Nov 17, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the flaky_tenant_test branch November 17, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants