Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test failures caused by instance drop failure #12002

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Nov 14, 2023

Fix #11329

PinotInstanceRestletResourceTest is flaky because instances are not cleaned up in PinotTenantRestletResourceTest

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7217bb9) 61.60% compared to head (0d45e0f) 46.83%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12002       +/-   ##
=============================================
- Coverage     61.60%   46.83%   -14.78%     
+ Complexity     1151      944      -207     
=============================================
  Files          2385     1787      -598     
  Lines        129250    93670    -35580     
  Branches      20007    15149     -4858     
=============================================
- Hits          79625    43870    -35755     
- Misses        43828    46693     +2865     
+ Partials       5797     3107     -2690     
Flag Coverage Δ
custom-integration1 ?
integration ?
integration1 ?
integration2 ?
java-11 ?
java-21 46.83% <ø> (-14.66%) ⬇️
skip-bytebuffers-false 46.79% <ø> (-14.81%) ⬇️
skip-bytebuffers-true 46.78% <ø> (-14.69%) ⬇️
temurin 46.83% <ø> (-14.78%) ⬇️
unittests 46.83% <ø> (-14.77%) ⬇️
unittests1 46.83% <ø> (-0.11%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 62abf1f into apache:master Nov 14, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_instance_drop_test branch November 14, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test]: PinotInstanceRestletResourceTest.instanceRetagHappyPathTest
3 participants