[multistage][hotfix] add back filter merge after rule #11989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11989 +/- ##
============================================
+ Coverage 61.61% 61.63% +0.02%
Complexity 207 207
============================================
Files 2385 2385
Lines 129214 129214
Branches 20003 20003
============================================
+ Hits 79613 79639 +26
+ Misses 43801 43773 -28
- Partials 5800 5802 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 18 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
xiangfu0
approved these changes
Nov 10, 2023
walterddr
added a commit
that referenced
this pull request
Nov 13, 2023
following up on #11989. adding more tests for filter pushdown rules on the runtime side. Co-authored-by: Rong Rong <rongr@startree.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason we missed this rule the whole time, adding it back