Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dateTimeConvert regression #11971

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Nov 8, 2023

fixing the regression introduced from: #11839

Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thanks for the quick fix! LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #11971 (5ea37e8) into master (b5e9823) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##             master   #11971      +/-   ##
============================================
- Coverage     61.43%   61.41%   -0.02%     
  Complexity      207      207              
============================================
  Files          2385     2385              
  Lines        129149   129150       +1     
  Branches      19994    19994              
============================================
- Hits          79342    79318      -24     
- Misses        44055    44075      +20     
- Partials       5752     5757       +5     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.37% <20.00%> (-0.02%) ⬇️
java-21 61.28% <20.00%> (+0.01%) ⬆️
skip-bytebuffers-false 61.41% <20.00%> (+0.01%) ⬆️
skip-bytebuffers-true 27.59% <0.00%> (-33.68%) ⬇️
temurin 61.41% <20.00%> (-0.02%) ⬇️
unittests 61.41% <20.00%> (-0.02%) ⬇️
unittests1 46.64% <20.00%> (-0.05%) ⬇️
unittests2 27.61% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/pinot/common/function/TransformFunctionType.java 89.15% <100.00%> (ø)
...a/org/apache/pinot/common/utils/PinotDataType.java 81.64% <0.00%> (-0.17%) ⬇️

... and 24 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@xiangfu0 xiangfu0 merged commit 972b555 into apache:master Nov 8, 2023
17 of 19 checks passed
@xiangfu0 xiangfu0 deleted the fixing-dateTimeConvert branch November 8, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants