Fix type cast issue with dateTimeConvert scalar function

[xiangfu0]

Right now dateTimeConvert is always cast for STRING in scalar function.
The return type should be LONG(BIGINT) for EPOCH or TIMESTAMP type and STRING for SIMPLE_DATE_FORMAT

This is discovered when running a query in v2:
SELECT DATETIMECONVERT(AGO('P32D'),'1:MILLISECONDS:EPOCH', '1:SECONDS:EPOCH', '1:SECONDS') from activity_full

Error:

ProcessingException(errorCode:150, message:SQLParsingError:
java.lang.Exception: Unable to find table for this query
	at org.apache.pinot.controller.api.resources.PinotQueryResource.getMultiStageQueryResponse(PinotQueryResource.java:210)
	at org.apache.pinot.controller.api.resources.PinotQueryResource.executeSqlQuery(PinotQueryResource.java:173)
	at org.apache.pinot.controller.api.resources.PinotQueryResource.handlePostSql(PinotQueryResource.java:121)
	at jdk.internal.reflect.GeneratedMethodAccessor366.invoke(Unknown Source)
...
Caused by: java.lang.RuntimeException: Error composing query plan for: SELECT DATETIMECONVERT(AGO('P32D'),'1:MILLISECONDS:EPOCH', '1:SECONDS:EPOCH', '1:SECONDS') from activity_full
	at org.apache.pinot.query.QueryEnvironment.getTableNamesForQuery(QueryEnvironment.java:241)
	at org.apache.pinot.controller.api.resources.PinotQueryResource.getMultiStageQueryResponse(PinotQueryResource.java:208)
	... 27 more
Caused by: java.lang.UnsupportedOperationException: Cannot generate a valid execution plan for the given query: LogicalProject(EXPR$0=[DATETIMECONVERT(AGO('P32D'), '1:MILLISECONDS:EPOCH', '1:SECONDS:EPOCH', '1:SECONDS')])
  LogicalTableScan(table=[[activity_full]])
	at org.apache.pinot.query.QueryEnvironment.optimize(QueryEnvironment.java:342)
	at org.apache.pinot.query.QueryEnvironment.compileQuery(QueryEnvironment.java:284)
	at org.apache.pinot.query.QueryEnvironment.getTableNamesForQuery(QueryEnvironment.java:237)
...
Caused by: org.apache.pinot.sql.parsers.SqlCompilationException: Caught exception while making literal with value: 1695011538 and type: BIGINT
	at org.apache.calcite.rel.rules.PinotEvaluateLiteralRule.evaluateLiteralOnlyFunction(PinotEvaluateLiteralRule.java:176)
	at org.apache.calcite.rel.rules.PinotEvaluateLiteralRule$EvaluateLiteralShuttle.visitCall(PinotEvaluateLiteralRule.java:131)
	at org.apache.calcite.rel.rules.PinotEvaluateLiteralRule$EvaluateLiteralShuttle.visitCall(PinotEvaluateLiteralRule.java:119)
	at org.apache.calcite.rex.RexCall.accept(RexCall.java:189)
...
Caused by: java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Number (java.lang.String and java.lang.Number are in module java.base of loader 'bootstrap')
	at org.apache.calcite.rex.RexBuilder.clean(RexBuilder.java:1721)
	at org.apache.calcite.rex.RexBuilder.makeLiteral(RexBuilder.java:1558)
	at org.apache.calcite.rex.RexBuilder.makeLiteral(RexBuilder.java:1520)
	at org.apache.calcite.rel.rules.PinotEvaluateLiteralRule.evaluateLiteralOnlyFunction(PinotEvaluateLiteralRule.java:174))

After fix:

[codecov-commenter]

Codecov Report

Merging #11839 (0658af2) into master (86d3c44) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master   #11839      +/-   ##
============================================
+ Coverage     66.35%   66.38%   +0.02%     
  Complexity      207      207              
============================================
  Files          2350     2350              
  Lines        127281   127284       +3     
  Branches      19603    19604       +1     
============================================
+ Hits          84463    84496      +33     
+ Misses        36924    36895      -29     
+ Partials       5894     5893       -1     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (ø)
integration	<0.01% <0.00%> (ø)
integration1	<0.01% <0.00%> (ø)
integration2	0.00% <0.00%> (ø)
java-11	66.34% <66.66%> (+0.01%)	⬆️
java-21	66.22% <66.66%> (+<0.01%)	⬆️
skip-bytebuffers-false	66.37% <66.66%> (+0.02%)	⬆️
skip-bytebuffers-true	66.19% <66.66%> (+48.38%)	⬆️
temurin	66.38% <66.66%> (+0.02%)	⬆️
unittests	66.38% <66.66%> (+0.02%)	⬆️
unittests1	67.15% <66.66%> (+0.03%)	⬆️
unittests2	17.83% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../pinot/common/function/scalar/DateTimeConvert.java	90.32% <66.66%> (-6.11%)	⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[walterddr]

lgtm