Fix the NPE in minimizeDataMovement instance assignment strategy #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks Jack 🙌 Keep me updated on the follow-up fix for the shifting replicaGroupId to different pool |
jackjlli
force-pushed
the
fix-npe-for-minimizeDataMovement
branch
from
d9832a4
to
d69374c
Compare
jackjlli
force-pushed
the
fix-npe-for-minimizeDataMovement
branch
from
d69374c
to
8315d89
Compare
Codecov Report
@@ Coverage Diff @@
## master #11952 +/- ##
=========================================
Coverage 61.40% 61.41%
Complexity 207 207
=========================================
Files 2378 2378
Lines 128902 128932 +30
Branches 19929 19939 +10
=========================================
+ Hits 79157 79185 +28
- Misses 44022 44034 +12
+ Partials 5723 5713 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
jackjlli
force-pushed
the
fix-npe-for-minimizeDataMovement
branch
from
8315d89
to
1841b56
Compare
Jackie-Jiang
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the NPE when
minimizeDataMovementis enabled and a new pool is added to the existing instance partition assignment.The problem of replicaGroupId mapping to a different pool will be handled in a separate PR.
Thanks @Ferix9288 for identifying the issue!
#11727
Unit test brought from this PR: #11765