Adding ability to fetch metadata for specific list of segments #11949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @snleee - Please review |
swaminathanmanish
force-pushed
the
segmentMetadataBatch
branch
from
68874d7
to
03c2001
Compare
Codecov Report
@@ Coverage Diff @@
## master #11949 +/- ##
============================================
+ Coverage 61.30% 61.45% +0.14%
+ Complexity 1140 207 -933
============================================
Files 2378 2385 +7
Lines 128865 129157 +292
Branches 19927 19997 +70
============================================
+ Hits 78998 79370 +372
+ Misses 44147 44027 -120
- Partials 5720 5760 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 77 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
snleee
approved these changes
Nov 3, 2023
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java
Show resolved
Hide resolved
swaminathanmanish
force-pushed
the
segmentMetadataBatch
branch
2 times, most recently
from
d03d917
to
a6c8a4d
Compare
swaminathanmanish
force-pushed
the
segmentMetadataBatch
branch
from
a6c8a4d
to
4ee5788
Compare
snleee
approved these changes
Nov 8, 2023
| */ | ||
| public JsonNode getSegmentsMetadata(String tableNameWithType, List<String> columns, int timeoutMs) | ||
| public JsonNode getSegmentsMetadata(String tableNameWithType, List<String> columns, Set<String> segmentsToInclude, |
There was a problem hiding this comment.
Add @Nullable to segmentsToInclude
| } | ||
|
|
||
| private JsonNode getSegmentsMetadataInternal(String tableNameWithType, List<String> columns, | ||
| Set<String> segmentsToInclude, int timeoutMs) |
There was a problem hiding this comment.
Add @Nullable to segmentsToInclude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Getting metadata for all segments leads to high heap utilization and even controller OOMs (especially when we have large number of segments and small controller heap). Typically we dont need metadata for all segments at once and this can be done in batches.
Solution:
Adding an API to fetch metadata for a list of segments. Also unified all APIs to use the same internal function. Did not modify existing APIs for backwards compatiblity.
Verified that existing functionality/apis work as expected
curl -X 'GET'
'http://localhost:9000/segments/airlineStats/metadata?type=OFFLINE'
-H 'accept: application/json'