Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for IN clause on constant STRING dictionary #11930

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

Fixes #11929

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #11930 (8bee7bd) into master (03a9ec7) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #11930      +/-   ##
============================================
- Coverage     61.42%   61.41%   -0.01%     
- Complexity     1141     1147       +6     
============================================
  Files          2378     2378              
  Lines        128845   128865      +20     
  Branches      19924    19927       +3     
============================================
+ Hits          79144    79148       +4     
- Misses        43983    43998      +15     
- Partials       5718     5719       +1     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 34.73% <0.00%> (-26.66%) ⬇️
java-21 61.29% <0.00%> (+<0.01%) ⬆️
skip-bytebuffers-false 61.40% <0.00%> (-0.02%) ⬇️
skip-bytebuffers-true 34.62% <0.00%> (-26.65%) ⬇️
temurin 61.41% <0.00%> (-0.01%) ⬇️
unittests 61.41% <0.00%> (-0.01%) ⬇️
unittests1 46.63% <0.00%> (-0.02%) ⬇️
unittests2 27.64% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t/index/readers/ConstantValueStringDictionary.java 20.68% <0.00%> (-5.40%) ⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit fee11d6 into apache:master Nov 2, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_npe_constant_dictionary branch November 2, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with IN predicate eval with multiple values with $SegmentName
3 participants