Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky OfflineClusterIntegrationTest on server response size tests #11926

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

The flakiness comes from the assert statement which can fail when table config change is not picked up by TableCache yet

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #11926 (b60db41) into master (8d49b11) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11926      +/-   ##
============================================
- Coverage     61.40%   61.40%   -0.01%     
- Complexity     1145     1147       +2     
============================================
  Files          2378     2378              
  Lines        128851   128851              
  Branches      19926    19926              
============================================
- Hits          79127    79126       -1     
+ Misses        44002    43996       -6     
- Partials       5722     5729       +7     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.39% <ø> (+26.65%) ⬆️
java-21 34.64% <ø> (-26.66%) ⬇️
skip-bytebuffers-false 61.40% <ø> (+0.01%) ⬆️
skip-bytebuffers-true ?
temurin 61.40% <ø> (-0.01%) ⬇️
unittests 61.40% <ø> (-0.01%) ⬇️
unittests1 46.62% <ø> (+<0.01%) ⬆️
unittests2 27.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 168d630 into apache:master Nov 1, 2023
17 of 19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_server_response_size_test branch November 1, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants