-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: show partial index in reload status #11913
UI: show partial index in reload status #11913
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11913 +/- ##
=========================================
Coverage 61.43% 61.44%
- Complexity 1146 1147 +1
=========================================
Files 2376 2378 +2
Lines 128773 128844 +71
Branches 19906 19925 +19
=========================================
+ Hits 79111 79163 +52
- Misses 43951 43952 +1
- Partials 5711 5729 +18
Flags with carried forward coverage won't be shown. Click here to find out more. see 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The change itself looks good. My concern is that we are pulling column level index info for every single segments, which can freeze the browser, or even crash the controller for large tables. IMO we don't need to show the index info when checking the reload status, just the segment count should be good enough. |
@Jackie-Jiang we already replaced that expensive API call with this one |
Oh nice, so it only returns the count! |
Description