Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] use indexes API instead of fetching all segment metadata #11793

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

walterddr
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #11793 (23b5dc2) into master (7124a03) will decrease coverage by 48.71%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11793       +/-   ##
=============================================
- Coverage     63.11%   14.41%   -48.71%     
+ Complexity     1117      201      -916     
=============================================
  Files          2342     2343        +1     
  Lines        125996   126312      +316     
  Branches      19378    19419       +41     
=============================================
- Hits          79528    18207    -61321     
- Misses        40804   106559    +65755     
+ Partials       5664     1546     -4118     
Flag Coverage Δ
integration ?
integration1 ?
integration2 ?
java-11 ?
java-17 14.41% <ø> (-48.55%) ⬇️
java-20 ?
temurin 14.41% <ø> (-48.71%) ⬇️
unittests 14.41% <ø> (-48.71%) ⬇️
unittests1 ?
unittests2 14.41% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1520 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr marked this pull request as ready for review October 12, 2023 07:16
@saurabhd336
Copy link
Contributor

@jayeshchoudhary

@Jackie-Jiang Jackie-Jiang added the ui UI related issue label Oct 13, 2023
Copy link
Contributor

@jayeshchoudhary jayeshchoudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though we are only covering two cases

  • index has value = 0 then Index is not present
  • otherwise present

will there be a case where the index is partially applied?
i.e not 0 value but not complete value either

@walterddr walterddr merged commit 2eacd30 into apache:master Oct 13, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants