Allowing custom transformers to be passed to SegmentProcessingFramework #11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
approved these changes
Oct 26, 2023
...cal/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #11887 +/- ##
============================================
- Coverage 61.43% 61.42% -0.02%
- Complexity 1146 1147 +1
============================================
Files 2375 2376 +1
Lines 128511 128779 +268
Branches 19848 19906 +58
============================================
+ Hits 78955 79102 +147
- Misses 43859 43956 +97
- Partials 5697 5721 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
swaminathanmanish
force-pushed
the
customTransformer
branch
from
da6598f
to
f405b28
Compare
swaminathanmanish
force-pushed
the
customTransformer
branch
from
f405b28
to
d19c6af
Compare
swaminathanmanish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need the ability to pass in custom RecordTransformers that can be used during map transformation (segment generation). Without this, users have to introduce custom RecordReaders where custom transformations have to be done. With customer RecordReaders, we no longer have control over allocations/deallocations of RecordReaders (eg: users can pass in long list of pre-allocated Parquet recordReaders which can result in holding up large heap allocations during segment generation and even result in OOM). Moreover we also have a well defined RecordTransformer interface just to do this transformation.
This PR allows users to pass custom RecordTransformers to SegmentProcessorFramework.