Fix the bug of reading decimal value stored in int32 or int64 in ParquetNativeRecordReader #11840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11840 +/- ##
============================================
+ Coverage 63.03% 63.06% +0.02%
Complexity 1141 1141
============================================
Files 2350 2350
Lines 127284 127293 +9
Branches 19604 19607 +3
============================================
+ Hits 80236 80279 +43
+ Misses 41339 41300 -39
- Partials 5709 5714 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snleee
approved these changes
Oct 20, 2023
.../src/main/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordExtractor.java
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordExtractor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for making this change. @xiangfu0 - How are we verifying this change ?
xiangfu0
force-pushed
the
more-parquet-fix
branch
from
6e184b1
to
7550f7b
Compare
snleee
approved these changes
Oct 20, 2023
.../src/main/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordExtractor.java
Show resolved
Hide resolved
xiangfu0
force-pushed
the
more-parquet-fix
branch
3 times, most recently
from
d8ea5ce
to
4e4d152
Compare
|
Added a test file to test logical types and just one simple test for decimal data type. |
xiangfu0
changed the title
18 tasks
xiangfu0
force-pushed
the
more-parquet-fix
branch
from
4e4d152
to
a25701b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Apache Parquet, decimal logical types can be represented by using either the
INT32,INT64, orFIXED_LEN_BYTE_ARRAYprimitive types, depending on the precision needed for the decimal numbers.The logical type specification includes two components: precision and scale.
Precision: The total number of digits that the decimal number can have.Scale: The number of digits that can appear after the decimal point.Here's how these map:
INT32: Suitable for decimal types that require up to 9 digits of precision.INT64: Suitable for decimal types that require up to 18 digits of precision.FIXED_LEN_BYTE_ARRAY: Suitable for decimal types that require more than 18 digits of precision. The length of the byte array would depend on the required precision.More Ref can be found here: https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal
This PR:
OriginalTypetoLogicalTypeAnnotation