-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow schema to be created with JSON config in UI #11809
Conversation
Please review - @ksnijjer @Jackie-Jiang |
Codecov Report
@@ Coverage Diff @@
## master #11809 +/- ##
============================================
+ Coverage 63.10% 63.24% +0.13%
+ Complexity 1140 1139 -1
============================================
Files 2343 2343
Lines 126306 126343 +37
Branches 19419 19439 +20
============================================
+ Hits 79703 79903 +200
+ Misses 40932 40758 -174
- Partials 5671 5682 +11
Flags with carried forward coverage won't be shown. Click here to find out more. see 38 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This is fantastic! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
do you have a demo that edit/paste a valid JSON and switch back to original view (does it shows the line items parsed properly?
No, we reset the config when the view gets changed. So you will see a fresh form when you change to simple view again same with JSON view. To make it simple and not introduce any bugs this is good imo. |
I think we can add this later. |
i dont really think we need to add later. simply have a banner warning when switching view "you have unsaved schema edit, do you want to proceed" is intuitive enough. and frankly i dont think any user will mix the view usages i asked the question simply want to make sure ppl arent allow to do exactly that |
this is
ui
,feature
Closes - #11789
Description
Screenshot
schema-add-json.mp4