Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pr test scripts and codecov #11804

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Oct 13, 2023

  • Separate pr test scripts
  • Ensure all test codecov are uploaded

@xiangfu0 xiangfu0 force-pushed the upload-code-cov branch 2 times, most recently from 8048319 to b47f686 Compare October 13, 2023 22:44
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #11804 (df00b74) into master (aff30d6) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11804      +/-   ##
============================================
- Coverage     63.08%   62.95%   -0.13%     
  Complexity     1140     1140              
============================================
  Files          2343     2343              
  Lines        126320   126320              
  Branches      19423    19423              
============================================
- Hits          79694    79530     -164     
- Misses        40953    41110     +157     
- Partials       5673     5680       +7     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (?)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 14.40% <ø> (-48.67%) ⬇️
java-17 62.96% <ø> (-0.01%) ⬇️
java-20 14.40% <ø> (-48.57%) ⬇️
temurin 62.95% <ø> (-0.13%) ⬇️
unittests 62.95% <ø> (-0.13%) ⬇️
unittests1 67.06% <ø> (-0.18%) ⬇️
unittests2 14.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 merged commit 1e04c8a into apache:master Oct 14, 2023
21 checks passed
@xiangfu0 xiangfu0 deleted the upload-code-cov branch October 14, 2023 00:07
@Jackie-Jiang
Copy link
Contributor

We used to have about 70% test coverage. Can you double check if all the coverage files are properly merged?

@xiangfu0 xiangfu0 mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants