Support Upsert deletion for TTL: construct queryableDocIds when adding segments out of TTL #11791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11791 +/- ##
=============================================
+ Coverage 34.84% 61.42% +26.57%
- Complexity 946 1147 +201
=============================================
Files 2299 2378 +79
Lines 124763 128880 +4117
Branches 19289 19927 +638
=============================================
+ Hits 43479 79166 +35687
+ Misses 78243 43997 -34246
- Partials 3041 5717 +2676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 853 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
| queryableDocIds = new MutableRoaringBitmap(); | ||
| // we allow passing null values for primaryKey columns and comparisonColumns to read deleteColumn to avoid paying | ||
| // the overhead of reading primary key, comparison column etc. They will never be null in other scenarios. | ||
| UpsertUtils.RecordInfoReader recordInfoReader = |
There was a problem hiding this comment.
Suggest not modifying the RecordInfoReader because it is not designed for this purpose. We can simply create a PinotSegmentColumnReader for _deleteRecordColumn, then iterate over the validDocIds
There was a problem hiding this comment.
when iterate the value of _deleteRecordColumn, can deletedRecord be null? can this be further optimize?
if (deleteRecordColumnReader.isNull(doc_id)) {
// defaultNullValue for deleteColumn is "false"
queryableDocIds.add(doc_id);
} else if (!(Boolean) deleteRecordColumnReader.getValue(doc_id)) {
queryableDocIds.add(doc_id);
}
deemoliu
force-pushed
the
upsert-ttl-deletion
branch
from
b604596
to
7c59d4a
Compare
deemoliu
force-pushed
the
upsert-ttl-deletion
branch
from
8a86e84
to
44c3e6d
Compare
deemoliu
force-pushed
the
upsert-ttl-deletion
branch
from
44c3e6d
to
d02bf67
Compare
Jackie-Jiang
approved these changes
Nov 3, 2023
|
thanks @Jackie-Jiang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix,upsert: construct queryableDocIds when adding segments out of TTLPreviously we don't handle cases that a upsert table with both upsert deletion and upsert ttl.
In this PR, fixed todo items, construct queryableDocIds when adding segments out of TTL.