reloadStatus should only count online segments #11787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11787 +/- ##
=========================================
Coverage 63.11% 63.12%
- Complexity 1117 1118 +1
=========================================
Files 2342 2342
Lines 125996 126010 +14
Branches 19378 19382 +4
=========================================
+ Hits 79528 79540 +12
- Misses 40804 40809 +5
+ Partials 5664 5661 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saurabhd336
approved these changes
Oct 12, 2023
walterddr
commented
Oct 12, 2023
| @@ -665,7 +665,7 @@ public ServerReloadControllerJobStatusResponse getReloadJobStatus( | |||
| serverToSegments.put(server, segmentList); | |||
| }); | |||
| } else { | |||
| serverToSegments = _pinotHelixResourceManager.getServerToSegmentsMap(tableNameWithType); | |||
| serverToSegments = _pinotHelixResourceManager.getServerToOnlineSegmentsMap(tableNameWithType); | |||
There was a problem hiding this comment.
i was actually thinking whether we should do 4 counts
- zk segment_cnt
- zk online_segment_cnt
- SUM(segment_cnt) from each server
- SUM(success_cnt) from each server
the logic to return success or failure will be based off 3==4, but if 3 != 2 we should do a warning. thoughts @Jackie-Jiang
|
merging this one first. we will continue discussion on #11785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reloadStatus should only count reloadable segments (ONLINE & CONUSMING) and exclude OFFLINE segments in ideal state.