Enhance Broker reducer to handle expression format change #11762
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11762 +/- ##
============================================
+ Coverage 63.12% 63.14% +0.01%
- Complexity 1118 1120 +2
============================================
Files 2342 2343 +1
Lines 125917 125976 +59
Branches 19370 19388 +18
============================================
+ Hits 79487 79542 +55
- Misses 40770 40788 +18
+ Partials 5660 5646 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
broker_column_name_change_handling
branch
from
2214fb8
to
3c0ef56
Compare
|
|
||
| AggregationDataTableReducer(QueryContext queryContext) { | ||
| public AggregationDataTableReducer(QueryContext queryContext) { |
There was a problem hiding this comment.
this and below: is public access needed? (not seeing any changes in how contructors are used
There was a problem hiding this comment.
Technically it is not required to be public, but it doesn't hurt since we don't really have a reason to prevent it from being reused
| // NOTE: When there is no cached data schema, that means all servers encountered exception. In such case, return the | ||
| // response with metadata only. | ||
| DataSchema cachedDataSchema = |
There was a problem hiding this comment.
(nit) notes are for line 139?
There was a problem hiding this comment.
The comment is about cached data schema, so I feel it is fine putting it here
Enhance broker reducer to not rely on the column names returned from the servers. This is required to support future expression format change (e.g. do not include single quotes around numeric literals).
0.12