Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BinaryArray to wire proto for multi-stage engine bytes literal handling #11738

Merged

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Oct 4, 2023

  1. Copy and modify RequestUtils.getLiteralExpression() to CalciteRexExpressionParser to separate the code path and handling for Literal expression
  2. Use ByteArray to wire proto binary data instead of byte[]

@xiangfu0 xiangfu0 force-pushed the fixing-binary-literal-leaf-stage-1 branch from 22fc747 to b28f95e Compare October 4, 2023 20:56
@xiangfu0 xiangfu0 force-pushed the fixing-binary-literal-leaf-stage-1 branch from b28f95e to 8f04044 Compare October 4, 2023 21:05
@codecov-commenter
Copy link

Codecov Report

Merging #11738 (8f04044) into master (c96221f) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master   #11738      +/-   ##
============================================
- Coverage     63.11%   63.05%   -0.07%     
- Complexity     1115     1118       +3     
============================================
  Files          2342     2342              
  Lines        125899   125898       -1     
  Branches      19364    19362       -2     
============================================
- Hits          79464    79381      -83     
- Misses        40780    40855      +75     
- Partials       5655     5662       +7     
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 14.40% <0.00%> (-48.65%) ⬇️
java-17 63.02% <25.00%> (+0.05%) ⬆️
java-20 62.98% <25.00%> (+0.03%) ⬆️
temurin 63.05% <25.00%> (-0.07%) ⬇️
unittests 63.04% <25.00%> (-0.07%) ⬇️
unittests1 67.11% <25.00%> (-0.12%) ⬇️
unittests2 14.47% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pache/pinot/common/utils/request/RequestUtils.java 61.90% <ø> (+2.36%) ⬆️
...inot/query/planner/logical/RexExpressionUtils.java 73.94% <100.00%> (ø)
...t/query/planner/serde/ProtoSerializationUtils.java 85.18% <0.00%> (+1.54%) ⬆️
...pinot/query/parser/CalciteRexExpressionParser.java 69.23% <28.57%> (-2.55%) ⬇️

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 merged commit 87996d2 into apache:master Oct 4, 2023
18 of 19 checks passed
@xiangfu0 xiangfu0 deleted the fixing-binary-literal-leaf-stage-1 branch October 4, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants