Change comment to be more precise #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gortiz
commented
Oct 4, 2023
| // In order to support null, the field needs to support _field presence_ | ||
| // See https://github.com/protocolbuffers/protobuf/blob/main/docs/field_presence.md | ||
| // or FieldDescriptor#hasPresence() | ||
| if (!fieldDescriptor.hasPresence() || message.hasField(fieldDescriptor)) { |
There was a problem hiding this comment.
Removing fieldDescriptor.isRepeated() because fieldDescriptor.hasPresence() already returns null when the field is repeated. It is also explicitly indicated in its javadoc.
Codecov Report
@@ Coverage Diff @@
## master #11735 +/- ##
============================================
- Coverage 62.95% 62.95% -0.01%
- Complexity 1114 1115 +1
============================================
Files 2342 2342
Lines 125919 125919
Branches 19362 19362
============================================
- Hits 79278 79267 -11
- Misses 40979 40991 +12
+ Partials 5662 5661 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a derivation of #11723, when @walterddr detected that a comment was not updated.