Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove split commit and some deprecated config for real-time protocol on controller #11663

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

  • Removed config of disabling split commit on controller (server can still decide whether to use split commit, but controller should support both)
  • Removed config of allowing HLC table on controller
  • Removed deprecated offset from controller protocol response

@Jackie-Jiang Jackie-Jiang added Configuration Config changes (addition/deletion/change in behavior) cleanup labels Sep 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Merging #11663 (d251ec9) into master (5b18145) will decrease coverage by 0.02%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##             master   #11663      +/-   ##
============================================
- Coverage     63.05%   63.03%   -0.02%     
+ Complexity     1121      207     -914     
============================================
  Files          2343     2343              
  Lines        125753   125725      -28     
  Branches      19321    19319       -2     
============================================
- Hits          79297    79257      -40     
- Misses        40809    40818       +9     
- Partials       5647     5650       +3     
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 63.00% <62.50%> (-0.03%) ⬇️
java-17 62.89% <62.50%> (-0.02%) ⬇️
java-20 62.90% <62.50%> (+<0.01%) ⬆️
temurin 63.03% <62.50%> (-0.02%) ⬇️
unittests 63.03% <62.50%> (-0.02%) ⬇️
unittests1 67.20% <100.00%> (-0.03%) ⬇️
unittests2 14.43% <12.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...va/org/apache/pinot/controller/ControllerConf.java 58.04% <ø> (+0.25%) ⬆️
...er/api/resources/LLCSegmentCompletionHandlers.java 0.00% <0.00%> (ø)
.../core/realtime/PinotLLCRealtimeSegmentManager.java 60.68% <0.00%> (-0.06%) ⬇️
...ot/common/protocols/SegmentCompletionProtocol.java 87.56% <100.00%> (+0.42%) ⬆️
.../helix/core/realtime/SegmentCompletionManager.java 70.63% <100.00%> (-0.04%) ⬇️
...manager/realtime/LLRealtimeSegmentDataManager.java 50.72% <100.00%> (-0.06%) ⬇️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mcvsubbu
Copy link
Contributor

lgtm , wdyt @sajjad-moradi

Copy link
Contributor

@sajjad-moradi sajjad-moradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackie-Jiang Jackie-Jiang merged commit 55309f2 into apache:master Sep 24, 2023
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the remove_controller_split_commit_config branch September 24, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Configuration Config changes (addition/deletion/change in behavior)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants