Rename ArrayIndexOfAll to ArrayIndexesOf #11654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiangfu0 @Jackie-Jiang Could you review this pr? |
Codecov Report
@@ Coverage Diff @@
## master #11654 +/- ##
============================================
- Coverage 63.06% 63.05% -0.01%
- Complexity 1118 1120 +2
============================================
Files 2342 2342
Lines 125690 125670 -20
Branches 19306 19296 -10
============================================
- Hits 79262 79246 -16
+ Misses 40778 40775 -3
+ Partials 5650 5649 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Sep 24, 2023
|
Thanks @wirybeaver for addressing them! Can you help also update the pinot documentation about these new functions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address pending comments of #11555
Rename arrayIndexOfAll -> arrayIndexesOf to align with ArrayUtils.indexesOf; Use fastutil.IntArray