modify the error response on controller. #11624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- return will always be JSON format if process error occurred. - when there's web/network/app issue, strictly non 2xx error code should be there for http response
Codecov Report
@@ Coverage Diff @@
## master #11624 +/- ##
=============================================
- Coverage 63.05% 14.46% -48.59%
+ Complexity 1105 201 -904
=============================================
Files 2325 2335 +10
Lines 124913 125216 +303
Branches 19146 19209 +63
=============================================
- Hits 78758 18110 -60648
- Misses 40533 105578 +65045
+ Partials 5622 1528 -4094
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1521 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Sep 20, 2023
| try { | ||
| return new BrokerResponseNative(pe).toJsonString(); | ||
| } catch (IOException ioe) { | ||
| throw new AssertionError("Should not reach this"); |
There was a problem hiding this comment.
Don't do assertion error in production code. You may use Utils.rethrowException(ioe) to workaround the checked exception if you prefer that way
Suggested change
| throw new AssertionError("Should not reach this"); | |
| throw new RuntimeException("Caught exception serializing the response", ioe); |
There was a problem hiding this comment.
yeah Utils rethrow should be the best. although it should never reach here anyway b/c the constructed response will always be a valid json.
Jackie-Jiang
added
enhancement
user-experience
walterddr
force-pushed
the
fix_controller_response
branch
from
3a8dfed
to
bba1d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
this fixes: #11593