In multi-stage aggregate, directly store column index as identifier #11617
+191
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
multi-stage
Jackie-Jiang
force-pushed
the
aggregate_pass_index
branch
from
e50179d
to
01c1200
Compare
Codecov Report
@@ Coverage Diff @@
## master #11617 +/- ##
============================================
- Coverage 63.08% 63.04% -0.05%
- Complexity 1106 1109 +3
============================================
Files 2326 2326
Lines 124942 124956 +14
Branches 19147 19152 +5
============================================
- Hits 78821 78777 -44
- Misses 40499 40555 +56
- Partials 5622 5624 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
aggregate_pass_index
branch
from
01c1200
to
9f1fd3f
Compare
walterddr
approved these changes
Sep 19, 2023
| arguments.add(ExpressionContext.forLiteralContext(literal)); | ||
| continue; | ||
| } | ||
| if (i >= numArguments) { |
There was a problem hiding this comment.
intermediate agg always have 1 real-argument (it cannot even be 0 b/c count would've been converted to SUM), and the rest are placeholders, why do we need to check the numArguments again here? simply do the loop with for (int i = 1 ... should be suffice?
There was a problem hiding this comment.
Separated the code path for raw input vs intermediate input
Jackie-Jiang
force-pushed
the
aggregate_pass_index
branch
from
9f1fd3f
to
8c91320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid constructing the column name to index map and converting back and forth