Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select testng as the test provider explicitly instead of relying on the classpath #11612

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

soumitra-st
Copy link
Contributor

I am adding testcases which brings in below dependencies:

    <dependency>
        <groupId>org.glassfish.jersey.test-framework</groupId>
        <artifactId>jersey-test-framework-core</artifactId>
        <version>2.26</version>
    </dependency>
    <dependency>
        <groupId>org.glassfish.jersey.test-framework.providers</groupId>
        <artifactId>jersey-test-framework-provider-grizzly2</artifactId>
        <version>2.26</version>
    </dependency>

However, these dependencies also pulls in junit jars, as a result of that the test provider becomes junit, and creates issues.

Hence, adding explicit configuration of test provider to testng for surefire plugin in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #11612 (b41f1cb) into master (49196ec) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11612   +/-   ##
=========================================
  Coverage     63.15%   63.15%           
  Complexity      207      207           
=========================================
  Files          2324     2324           
  Lines        124534   124534           
  Branches      18994    18994           
=========================================
+ Hits          78645    78647    +2     
+ Misses        40302    40299    -3     
- Partials       5587     5588    +1     
Flag Coverage Δ
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 50.11% <ø> (ø)
java-17 63.01% <ø> (ø)
java-20 67.26% <ø> (+4.24%) ⬆️
temurin 63.15% <ø> (+<0.01%) ⬆️
unittests 63.14% <ø> (+<0.01%) ⬆️
unittests1 67.45% <ø> (+<0.01%) ⬆️
unittests2 14.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 merged commit 7fb47f0 into apache:master Sep 18, 2023
23 checks passed
@Jackie-Jiang Jackie-Jiang added dependencies Pull requests that update a dependency file testing labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants