Disallow peer download when replication is < 2 #11469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11469 +/- ##
=============================================
- Coverage 63.07% 0.00% -63.08%
=============================================
Files 2325 2249 -76
Lines 124772 121043 -3729
Branches 19052 18497 -555
=============================================
- Hits 78696 0 -78696
- Misses 40475 121043 +80568
+ Partials 5601 0 -5601
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1981 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can you please rebase and fix the test? |
saurabhd336
force-pushed
the
peerDownloadSchemeValidation
branch
from
4888c40
to
450ac31
Compare
|
@xiangfu0 thanks for reviewing. Tests have been fixed. |
Jackie-Jiang
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow peer download when replication is < 2