Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade testng version to 7.8.0 #11462

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Aug 30, 2023

  • Upgrade Testng to 7.8.0
  • Upgrade Maven surefire version to 3.1.2
  • Simplify maven-surefire-plugin usage in other module
  • Fixing some flaky tests in OfflineClusterIntegrationTest

@xiangfu0 xiangfu0 force-pushed the upgrade-testng-version branch 10 times, most recently from 5394b20 to 8e84aa4 Compare August 30, 2023 14:12
@xiangfu0 xiangfu0 force-pushed the upgrade-testng-version branch 6 times, most recently from c0ffa31 to 1eee7ed Compare September 20, 2023 17:51
@apache apache deleted a comment from codecov-commenter Sep 20, 2023
@xiangfu0 xiangfu0 force-pushed the upgrade-testng-version branch 6 times, most recently from 28d2918 to b26d22a Compare September 25, 2023 06:58
@xiangfu0 xiangfu0 force-pushed the upgrade-testng-version branch 5 times, most recently from 863eccc to 5a7c60c Compare October 1, 2023 06:53
@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Oct 1, 2023

finally got this upgraded after fixing this: #11720

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #11462 (cece797) into master (9b39d94) will decrease coverage by 4.15%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11462      +/-   ##
============================================
- Coverage     67.22%   63.07%   -4.15%     
+ Complexity      915      207     -708     
============================================
  Files          1747     2342     +595     
  Lines         91052   125883   +34831     
  Branches      14613    19357    +4744     
============================================
+ Hits          61206    79400   +18194     
- Misses        25726    40825   +15099     
- Partials       4120     5658    +1538     
Flag Coverage Δ
integration <0.01% <ø> (?)
integration1 <0.01% <ø> (?)
integration2 0.00% <ø> (?)
java-11 63.04% <ø> (-4.18%) ⬇️
java-17 62.95% <ø> (?)
java-20 14.41% <ø> (?)
temurin 63.07% <ø> (-4.15%) ⬇️
unittests 63.06% <ø> (-4.16%) ⬇️
unittests1 67.23% <ø> (+0.01%) ⬆️
unittests2 14.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 666 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 merged commit e0a1f62 into apache:master Oct 2, 2023
21 checks passed
@xiangfu0 xiangfu0 deleted the upgrade-testng-version branch October 2, 2023 22:45
@deemoliu
Copy link
Contributor

deemoliu commented Oct 3, 2023

hi @xiangfu0

I observed some command are not working after test verison bump.

For example

mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip

and I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project pinot-spi: No tests matching pattern "InterSegmentAggregationMultiValueRawQueriesTest" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :pinot-spi

do you have an equivalent testing command that has similar function with mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip?

@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Oct 4, 2023

hi @xiangfu0

I observed some command are not working after test verison bump.

For example

mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip

and I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project pinot-spi: No tests matching pattern "InterSegmentAggregationMultiValueRawQueriesTest" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :pinot-spi

do you have an equivalent testing command that has similar function with mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip?

True, I can also reproduce this, will look into it more.
For now you can enter into the folder then run it:

cd pinot-core
mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip

@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Oct 4, 2023

hi @xiangfu0

I observed some command are not working after test verison bump.

For example

mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip

and I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project pinot-spi: No tests matching pattern "InterSegmentAggregationMultiValueRawQueriesTest" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :pinot-spi

do you have an equivalent testing command that has similar function with mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip?

you can use -Dsurefire.failIfNoSpecifiedTests=false instead of -DfailIfNoTests=false

@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Oct 4, 2023

hi @xiangfu0
I observed some command are not working after test verison bump.
For example

mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip

and I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project pinot-spi: No tests matching pattern "InterSegmentAggregationMultiValueRawQueriesTest" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :pinot-spi

do you have an equivalent testing command that has similar function with mvn test -Dtest=InterSegmentAggregationMultiValueRawQueriesTest -DfailIfNoTests=false -Dcheckstyle.skip?

you can use -Dsurefire.failIfNoSpecifiedTests=false instead of -DfailIfNoTests=false

for simplicity, this is the most effective way:

mvn test  -pl :pinot-core -am  "-Dtest=*InterSegmentAggregationMultiValueRawQueriesTest"  -Dcheckstyle.skip -Dsurefire.failIfNoSpecifiedTests=false

@deemoliu
Copy link
Contributor

deemoliu commented Oct 4, 2023

i see. thanks @xiangfu0, i tried the last command and it worked perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants