Update the pinot tenants tables api to support returning broker tagged tables #11184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11184 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2229 2229
Lines 119803 119827 +24
Branches 18126 18130 +4
==========================================
Hits 137 137
- Misses 119646 119670 +24
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Jul 28, 2023
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java
Show resolved
Hide resolved
...ller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java
Show resolved
Hide resolved
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is authored by @priyen and is a small
featureaddition.This updates the
tenants/{tenantName}/tablesAPI to support also specifying type to return tagged tables by the broker tenant. Tables can have separate broker and server tenants, so this allows us to actually get both.Previously:
/tenants/{tenantName}/tables-> returns tables with that server tagNow:
/tenants/{tenantName}/tables-> returns tables with that server tag/tenants/{tenantName}/tables?type=server-> returns tables with that server tag/tenants/{tenantName}/tables?type=broker-> returns tables with that broker tagWe are already using this successfully in our fork, and unit tests are included