feat(ui): persist oidc auth details #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10389 +/- ##
=============================================
- Coverage 64.25% 13.87% -50.39%
+ Complexity 6059 259 -5800
=============================================
Files 1997 1997
Lines 108768 108768
Branches 16620 16620
=============================================
- Hits 69888 15090 -54798
- Misses 33816 92452 +58636
+ Partials 5064 1226 -3838
Flags with carried forward coverage won't be shown. Click here to find out more. see 1355 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jayeshchoudhary
changed the title
| const { authenticated, authWorkflow } = useAuthProvider(); | ||
| const history = useHistory(); | ||
|
|
||
| React.useEffect(() => { |
There was a problem hiding this comment.
Minor and not a blocker: can you pleease fix the import so that you can use just useEffect?
|
Looks good. |
Jackie-Jiang
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is
uifeatureIssue
Solution
Note
The solution is only implemented for OIDC authentication. Other auth methods will work as before.
Reviewers - @apucher @joshigaurava @mayankshriv