Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13601 Add code-coverage workflow #9126

Closed
wants to merge 2 commits into from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-13601 Adds a code-coverage workflow to the set of GitHub Action workflows to handle running both unit tests and integration tests on a daily schedule. The code-coverage workflow also handles publishing code coverage metrics to Codecov, removing this step for the ci-workflow.

Additional changes include removing the scheduled settings for other test workflows as this workflow covers all types of tests and provides a daily status.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Removed scheduled execution of other testing workflows
- Added weekly schedule for docker-tests
@exceptionfactory
Copy link
Contributor Author

Thanks for the feedback @ChrisSamo632! I pushed a commit adding the NiFi Registry integration tests profile to the code-coverage workflow and adjusted the docker-tests workflow to run once a week.

Copy link
Contributor

@ChrisSamo632 ChrisSamo632 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the change @exceptionfactory , will merge

@asfgit asfgit closed this in 7e200fa Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants