NIFI-12188 Upgraded Commons Net from 3.9.0 to 3.10.0 #7855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed ProxyFTPClient extension of standard FTPClient no longer required following changes implemented in NET-650
|
nice. will keep an eye out on the test runs and merge later on. The bom pr i'll look into as well if someone doesn't grab first but that one is far more adventurous! |
pvillard31
approved these changes
Oct 9, 2023
asfgit
pushed a commit
that referenced
this pull request
Oct 9, 2023
- Removed ProxyFTPClient extension of standard FTPClient no longer required following changes implemented in NET-650 Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes #7855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12188 Upgrades Apache Commons Net from 3.9.0 to 3.10.0, which incorporates several bug fixes and improvements.
Improvements in Commons Net 3.10.0 include resolving NET-650, which delegates host resolution to
java.net.Socket.connect()methods, improving support for access through HTTP or SOCKS5 proxy servers. This improvement obviates the need for the Apache NiFiProxyFTPClient, which is removed along with the associated unit test class.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation