-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-11793: Added documentation to indicate how to debug Python side … #7469
Conversation
…of nifi framework, as well as debugging python processors themselves using VSCode's Remote debugger. This also provides the ability to launch the Controller process in such a way that it will listen to incoming remote debug connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement and documentation @markap14. The new properties and documentation look good in general, I just noted a couple minor property naming recommendations.
@@ -87,6 +111,11 @@ public static class Builder { | |||
private Duration commsTimeout = Duration.ofSeconds(0); | |||
private int maxProcesses; | |||
private int maxProcessesPerType; | |||
private boolean debugController = true; // TODO: Make this default to false and get config from nifi.properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is driven from nifi.properties and defaulted to false
, so can this be set to false
, along with removing the comment?
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
Outdated
Show resolved
Hide resolved
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement and documentation @markap14. The new properties and documentation look good in general, I just noted a couple minor property naming recommendations.
…l/NiFiProperties.java Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…l/NiFiProperties.java Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
Thanks @exceptionfactory , agreed on the naming. Have updated and pushed new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the adjustments @markap14, the latest version looks good! +1 merging
…of nifi framework, as well as debugging python processors themselves using VSCode's Remote debugger.
This also provides the ability to launch the Controller process in such a way that it will listen to incoming remote debug connections.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation