NIFI-13709 Added more meaningful message when validation fails with n…

…on-compliant XML is validated and no schema is provided. Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes #9229.
apache · Sep 5, 2024 · 727b0ba · 727b0ba
1 parent 5f0cbed
commit 727b0ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...fi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java b/...fi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java
@@ -217,7 +217,7 @@ private void validate(final InputStream in) {
                     reader.next();
                 }
             } catch (final XMLStreamException e) {
-                throw new ProcessingException("Reading stream failed", e);
+                throw new ProcessingException("Reading stream failed: " + e.getMessage(), e);
             }
         } else {
             final XMLStreamReaderProvider readerProvider = new StandardXMLStreamReaderProvider();

diff --git a/...tandard-processors/src/test/java/org/apache/nifi/processors/standard/TestValidateXml.java b/...tandard-processors/src/test/java/org/apache/nifi/processors/standard/TestValidateXml.java
@@ -168,6 +168,8 @@ public void testInvalidXMLAttributeStructure() {
 
         runner.assertAllFlowFilesTransferred(ValidateXml.REL_INVALID, 1);
         runner.assertAllFlowFilesContainAttribute(ValidateXml.REL_INVALID, ValidateXml.ERROR_ATTRIBUTE_KEY);
+        String errorAttribute = runner.getFlowFilesForRelationship(ValidateXml.REL_INVALID).get(0).getAttribute(ValidateXml.ERROR_ATTRIBUTE_KEY);
+        assertTrue(errorAttribute.contains("ParseError"));
     }
 
     @Test
@@ -191,5 +193,7 @@ public void testInvalidXMLContentStructure() {
 
         runner.assertAllFlowFilesTransferred(ValidateXml.REL_INVALID, 1);
         runner.assertAllFlowFilesContainAttribute(ValidateXml.REL_INVALID, ValidateXml.ERROR_ATTRIBUTE_KEY);
+        String errorAttribute = runner.getFlowFilesForRelationship(ValidateXml.REL_INVALID).get(0).getAttribute(ValidateXml.ERROR_ATTRIBUTE_KEY);
+        assertTrue(errorAttribute.contains("ParseError"));
     }
 }