Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot of APIS as of NetBeans 23 #7770

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

ebarboni
Copy link
Contributor

@ebarboni ebarboni commented Sep 19, 2024

Snapshot of APIs as of NetBeans 23

# checkout branch (or release tag)
git checkout release230
git clean -dxf
ant build
ant gen-sigtests-release
git add -A
git stash
git checkout master
git checkout -b apis-nb240a1
git stash pop
git add -A
git commit -m "Snapshot of APIS as of NetBeans 23"
# remove getPeer() calls
find . -name "*.sig" -exec sed -i '/java.awt.peer.ComponentPeer/{N;d;}' {} \;
# check git diff
git add -A
git commit --amend

Filtered diff created using -

curl -L https://github.com/apache/netbeans/pull/<PR_ID>.diff | filterdiff -#2- > filtered-apis-nb230.txt

filtered-apis-nb230.txt

@ebarboni ebarboni added the Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes. label Sep 19, 2024
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw nothing obviously wrong here.

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, looks fine at a glance.

This needs to be done initially around rc1 as @jtulach has pointed out - reviewing after release can't catch unintended API changes.

@ebarboni
Copy link
Contributor Author

wiki edited to make it better next time :D

@neilcsmith-net
Copy link
Member

Thanks @ebarboni Need to possibly review if anything else is missing from that page that got added to the schedule (plugin redirect update with rc3 comes to mind) - let's follow up on that elsewhere.

@ebarboni
Copy link
Contributor Author

will merge later today

@ebarboni ebarboni merged commit cd0213d into apache:master Sep 25, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants