Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy compatible max min #16046

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Numpy compatible max min #16046

merged 2 commits into from
Aug 31, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Aug 30, 2019

Description

numpy compatible max min

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@stu1130 stu1130 force-pushed the numpy_max_min branch 2 times, most recently from e491fd0 to 6a4f7b1 Compare August 30, 2019 05:30
@stu1130 stu1130 changed the title numpy compatible max min Numpy compatible max min Aug 30, 2019
@reminisce
Copy link
Contributor

@gigasquid We have seen the same failure in a couple of PRs. Do you have any idea where is wrong? Thanks.
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16046/5/pipeline/276

@yzhliu yzhliu mentioned this pull request Aug 30, 2019
7 tasks
@reminisce reminisce merged commit aab4ded into apache:master Aug 31, 2019
zixuanweeei pushed a commit to zixuanweeei/mxnet that referenced this pull request Sep 2, 2019
* numpy compatible max min

* retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants