Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

julia: rename build env var MXNET_HOME to MXNET_ROOT #15568

Merged
merged 11 commits into from
Sep 8, 2019
Merged

julia: rename build env var MXNET_HOME to MXNET_ROOT #15568

merged 11 commits into from
Sep 8, 2019

Conversation

iblislin
Copy link
Member

  • Add MXNET_LIBRARY_PATH support

Ref: #15561

@iblislin iblislin marked this pull request as ready for review July 17, 2019 08:08
aaronmarkham
aaronmarkham reviewed Jul 17, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is great to clarify environment variables. Does this introduce some backwards incompatibility for any users? I wonder if we should hold this kind of change for a minor release... like 1.6.
That way, my patch can go in and we can resume publishing the website.

If we continue to have issues, or if we go through testing on this PR and update my PR to use the new env var MXNET_ROOT, I'll want to disable Julia docs in settings.ini in another PR, so we can get the website back to publishing regularly.

@iblislin
Copy link
Member Author

Does this introduce some backwards incompatibility for any users?

I can make it backward compatible in this PR, and your PR will work fine.
I want to merge your PR first, and get the backward compatibility tested in this PR.

@iblislin
Copy link
Member Author

okay, I added backward compatibility.

@iblislin
Copy link
Member Author

okay, the build of 409ce0e looks fine.

@piyushghai
Copy link
Contributor

@iblis17 Can you resolve the merge conflicts and take this PR forward ?

marcoabreu
marcoabreu approved these changes Sep 7, 2019
View reviewed changes
julia/deps/build.jl Outdated Show resolved Hide resolved
@iblislin iblislin mentioned this pull request Sep 7, 2019
Closed
@iblislin iblislin merged commit 75ee1e9 into master Sep 8, 2019
@iblislin iblislin deleted the ib/jl-mxnet-root-env branch September 8, 2019 04:31
@aaronmarkham aaronmarkham mentioned this pull request Sep 11, 2019
Closed
@aaronmarkham
Copy link
Contributor

@iblis17 Hi Iblis, I'd like to revert this change since it caused the website to stop publishing.
Let's get the new site up and apply the updates then. Also, changes will be much easier to test.

aaronmarkham added a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2019
@aaronmarkham
Revert "julia: rename build env var MXNET_HOME to MXNET_ROOT (apa…
32b9efe 
…che#15568)"

This reverts commit 75ee1e9.
anirudh2290 pushed a commit that referenced this pull request Sep 12, 2019
@aaronmarkham @anirudh2290
Revert "julia: rename build env var MXNET_HOME to MXNET_ROOT (#15568
61e8347 
)" (#16147)

This reverts commit 75ee1e9.
@iblislin
Copy link
Member Author

oh, @aaronmarkham what are the recent changes on the website builds?

@aaronmarkham
Copy link
Contributor

oh, @aaronmarkham what are the recent changes on the website builds?

The code isn't merged yet, but we're close. Info is here: https://cwiki.apache.org/confluence/display/MXNET/Building+the+New+Website

Basically, with the new flow, after you've generated the MXNet binary (with a similar single command), you can run this to test the Julia docs build. Then you don't have to worry about Sphinx or any other dependency than the MXNet binary and just focus on Julia.

ci/build.py --docker-registry mxnetci --platform ubuntu_cpu_julia /work/runtime_functions.sh build_julia_docs

larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@iblislin @larroy
julia: rename build env var MXNET_HOME to MXNET_ROOT (apache#15568)
5ca00db 
* julia: rename build env var `MXNET_HOME` to `MXNET_ROOT`

- Add MXNET_LIBRARY_PATH support

Ref: apache#15561

* backward compatibility
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@aaronmarkham @larroy
Revert "julia: rename build env var MXNET_HOME to MXNET_ROOT (apa…
6f75c1a 
…che#15568)" (apache#16147)

This reverts commit 75ee1e9.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham aaronmarkham left review comments

@marcoabreu marcoabreu marcoabreu approved these changes

Assignees
No one assigned
Labels
Build Julia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iblislin @piyushghai @aaronmarkham @marcoabreu