Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKLDNN] reorder the mem format for the AddBack mode in case src & dst is different #11095

Closed
wants to merge 1 commit into from
Closed

[MKLDNN] reorder the mem format for the AddBack mode in case src & dst is different #11095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/operator/nn/mkldnn/mkldnn_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,14 @@ void CommitOutput(const NDArray &arr, const mkldnn_output_t &res) {
if (res.first == CopyBack) {
const_cast<NDArray &>(arr).CopyFrom(*res.second);
} else if (res.first == AddBack) {
auto mem = arr.GetMKLDNNData(res.second->get_primitive_desc());
CHECK(mem != nullptr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether it works if we just use GetMKLDNNDataReorder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can work but it will be a little confusion to call reorder API for all cases.

const mkldnn::memory *mem = arr.GetMKLDNNData();
auto arr_desc = mem->get_primitive_desc();
auto res_desc = res.second->get_primitive_desc();
if (arr_desc == res_desc) {
mem = arr.GetMKLDNNData(res_desc);
} else {
mem = arr.GetMKLDNNDataReorder(res_desc);
}
// We have to allocate new memory for the sum result.
auto sum_res = TmpMemMgr::Get()->Alloc(
res.second->get_primitive_desc());
Expand Down