Use Maven Wrapper to build

[cstamas]

And do not rely on third party tools as they
may do things that surprise us.

[slawekjaranowski]

or we can add:

      - name: Set up Maven
        run:
          mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.3.2:wrapper "-Dmaven=3.9.7"

[laeubi]

There is a setup-maven action:
https://github.com/marketplace/actions/setup-maven

I use it all the time without any issues and you can perfectly control the maven version.

[cstamas]

There is a setup-maven action: https://github.com/marketplace/actions/setup-maven

I use it all the time without any issues and you can perfectly control the maven version.

We use that action, and the last IT failures made us realize how strange it behaves: it set up different Maven versions per OS:

• ubuntu 3.8.8
• windows 3.8.7
• macos 3.9.7

True, we did not ask for specific maven version, but that is not the point. We should use wrapper anyway to be able to precisely control which Maven version we want to use (across all OSes) but also for dogfooding purposes.

See
https://github.com/apache/maven/actions/runs/9322027451/job/25662372003?pr=1546
https://github.com/apache/maven/actions/runs/9322027451/job/25662372450?pr=1546
https://github.com/apache/maven/actions/runs/9322027451/job/25662372946?pr=1546

[laeubi]

and the last IT failures made us realize how strange it behaves: it set up different Maven versions per
True, we did not ask for specific maven version, but that is not the point.

Well I would call it strange to use an action without specify a version ... I mean even the readme tells you to specify one, i more suspect that without a version nothing is done actually....

[gnodet]

There is a setup-maven action: https://github.com/marketplace/actions/setup-maven
I use it all the time without any issues and you can perfectly control the maven version.

We use that action, and the last IT failures made us realize how strange it behaves: it set up different Maven versions per OS:

I can't see the use of this action for ITs. We do use actions/setup-java, but not actions/setup-maven. I would think reusing this action in the context of GH action makes more sense.

[laeubi]

I can't see the use of this action for ITs. We do use actions/setup-java, but not actions/setup-maven. I would think reusing this action in the context of GH action makes more sense.

Maybe it is confused with setup-java having support for maven toolchains and caching option named maven ...

If one wants there is a composite action https://github.com/marketplace/actions/setup-maven-action but I usually found setup-java/maven enough and more flexible.

[rmannibucau]

setup-java uses OS maven version which is likely not what we want.
Guess we should reuse our shared action enabling to support setup-maven to have a build matrix (ideally).

[laeubi]

setup-java has nothing to do with installing / "using" maven it just do the following:

• generates toolchain.xml from installed jdks
• uses pom.xml files as cache keys

beside that I hope that the itest are using the maven that was build anyways (so a matrix des not make much sense here), so whats left is that the maven version to run the build is better specified explicitly to prevent any surprise.

[cstamas]

Well I would call it strange to use an action without specify a version ... I mean even the readme tells you to specify one, i more suspect that without a version nothing is done actually....

You are mixing things. Again, we do NOT use setup-maven action, hence the readme you point it is... off topic.

[cstamas]

IMHO we should not use any action to setup Maven but wrapper.... that's my 5 cents (we even have examples of "maven matrix" that is simply doable with wrapper).

[laeubi]

You are mixing things. Again, we do NOT use setup-maven action, hence the readme you point it is... off topic.

I mentioned you need to use setup-maven action, you replied that

We use that action, and the last IT failures made us realize how strange it behaves

so I obviously do not mix up anything here but maybe you have just misread my reply...

[gnodet]

Actually, we're not using it... I thought, but the matrix is used with wrapper

https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml#L196-L198

So I'm fine using wrapper here too.

[slawekjaranowski]

before this step we can also add step Set up Maven with wrapper
and we not need add wrapper properties and scripts to code

[slawekjaranowski]

I hope it is ready to merge @cstamas @gnodet what do you think

[cstamas]

Superseded by #1550

[slawekjaranowski]

#1550 is for master ... this one was for 3.x branch

[slawekjaranowski]

I will create a new one for 3.x 😄

[slawekjaranowski]

Done in #1553