Resolver updates #1495
Merged
Resolver updates #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnodet
commented
May 2, 2024
•
gnodet
commented
- Resolver updates
- Remove a few other references
cstamas
reviewed
May 2, 2024
| @@ -116,17 +116,6 @@ public Artifact setVersion(String version) { | |||
| return new RelocatedArtifact(artifact, groupId, artifactId, classifier, extension, version, message); | |||
| } | |||
|
|
|||
| @Deprecated | |||
| @Override | |||
| public Artifact setFile(File file) { | |||
There was a problem hiding this comment.
maven-resolver-provider RelocatedArtifact is present in mvn3 as well, I mean "binary compat"
There was a problem hiding this comment.
Mmh, not sure, as a default implementation is provided by AbstractArtifact... ?
There was a problem hiding this comment.
I've reverted the removal of the two setFile() methods to be safe.
This reverts commit 144bc73.
cstamas
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.