[MNG-8082] - Exceptions of proxied SessionScoped components are not working correctly #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orking correctly Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
cstamas
approved these changes
Mar 23, 2024
rmannibucau
approved these changes
Mar 23, 2024
CrazyHZM
requested changes
Mar 24, 2024
| try { | ||
| return method.invoke(getScopeState().scope(key, unscoped).get(), args); | ||
| } catch (InvocationTargetException e) { | ||
| throw e.getCause(); |
There was a problem hiding this comment.
If the target Exception is null, it will throw NPE, and this could affect exception tracing.
There was a problem hiding this comment.
the variable e can never be null.
The statement e.getCause() can be null in theory, but in practice I don't see any case which could give this.
Additional if the cause will be null, we will loose the exception tracing in any case (the only difference is the exception class NullPointerException vs. InvocationTargetException and line number).
There was a problem hiding this comment.
e.getCause() return target. I mean e.g Cause() is null, which can affect line numbers.
gnodet
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to handle the exception case correctly.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.