[MNG-6303] Interpolate user supplied properties and command line arguments #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
MNG-6303-properties-interpolation
branch
from
898fa83
to
c7644da
Compare
gnodet
changed the title
elharo
requested changes
Mar 17, 2023
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
Outdated
Show resolved
Hide resolved
gnodet
force-pushed
the
MNG-6303-properties-interpolation
branch
from
55bae88
to
7446b30
Compare
gnodet
force-pushed
the
MNG-6303-properties-interpolation
branch
from
4f863c5
to
8de0a56
Compare
elharo
reviewed
Apr 15, 2023
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
gnodet
force-pushed
the
MNG-6303-properties-interpolation
branch
from
8de0a56
to
d73a098
Compare
elharo
approved these changes
Apr 20, 2023
cstamas
approved these changes
Apr 24, 2023
|
I need a bit more time to review it. |
michael-o
requested changes
May 5, 2023
michael-o
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MNG-6303
The idea is to allow user properties interpolation for command line arguments from both CLI and
.mvn/maven.config.User properties are interpolated first, then all other arguments.
This PR depends on #1061