Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAR-296] Allow including files excluded by default. #67

Merged

Conversation

redzi
Copy link
Contributor

@redzi redzi commented Nov 19, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAR-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAR-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Underlining issue: MJAR-296.
Goal:

  • allow to include in the resulting archive files that are excluded by default - e.g. .gitignore, etc.

@redzi redzi force-pushed the MJAR-296-suppress-default-excludes branch from 4e85e6c to f811a85 Compare November 20, 2023 21:40
Comment on lines 28 to 31
if ( !target.exists() || !target.isDirectory() ) {
System.err.println( "target file is missing or not a directory." )
return result
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simply use:

assert  target.isDirectory()

@slawekjaranowski slawekjaranowski force-pushed the MJAR-296-suppress-default-excludes branch from f811a85 to bd967a2 Compare April 8, 2024 21:32
@slawekjaranowski
Copy link
Member

@redzi , @michael-o - fixed and tested - should be ok

@michael-o michael-o self-requested a review April 9, 2024 09:23
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit from my side, but the rest is fine!

@slawekjaranowski slawekjaranowski merged commit 5e31b99 into apache:master Apr 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants