Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1104] Four element pattern may be GATV or GATC #29

Merged
merged 6 commits into from
Jul 17, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jul 15, 2022

This simple patch makes 4 element pattern
be interpeted as GATV (as before) or as GATC.

Also, cleanup how patterns are created, make
everywhere toPattern static helper is used, no need
for direct ctor invocation, and it simplifies things.


https://issues.apache.org/jira/browse/MSHARED-1104

This simple patch makes 4 element pattern
be interpeted as GATV (as before) or as GATV
@cstamas cstamas requested review from gnodet and michael-o July 15, 2022 21:50
@cstamas cstamas self-assigned this Jul 15, 2022
@cstamas cstamas changed the title GATV or GATC [MSHARED-1104] Four element pattern may be GATV or GATC Jul 16, 2022
@cstamas cstamas marked this pull request as ready for review July 16, 2022 08:31
@cstamas cstamas merged commit 611baf6 into master Jul 17, 2022
@cstamas cstamas deleted the gatv-or-gatc branch July 17, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants