Skip to content

Commit

Permalink
[MSHARED-1077] Bugfix for classifier in pattern (#26)
Browse files Browse the repository at this point in the history
Parsing of pattern with classifier was busted, that
prevented use cases like before [rewrite](4a6f6d6), that was again
busted due early return (not happening since rewrite, but since rewrite
we do no support classifiers in patterns).

So, here is yet another rewrite, that not only fixes old use cases (w/ classifier)
but also makes it even more faster. Last, but not least, new code is 
now in high level Java, instead of `char[][]` and is self documenting.
  • Loading branch information
cstamas committed Jun 11, 2022
1 parent 72981e4 commit 0c6674f
Show file tree
Hide file tree
Showing 5 changed files with 1,395 additions and 620 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public PatternExcludesArtifactFilter( Collection<String> patterns, boolean actTr
super( patterns, actTransitively );
}

/** {@inheritDoc} */
@Override
public boolean include( Artifact artifact )
{
boolean shouldInclude = !patternMatches( artifact );
Expand All @@ -66,21 +66,13 @@ public boolean include( Artifact artifact )
return shouldInclude;
}

/**
* {@inheritDoc}
*
* @return a {@link java.lang.String} object.
*/
@Override
protected String getFilterDescription()
{
return "artifact exclusion filter";
}

/**
* {@inheritDoc}
*
* @return a {@link java.lang.String} object.
*/
@Override
public String toString()
{
return "Excludes filter:" + getPatternsAsString();
Expand Down
Loading

0 comments on commit 0c6674f

Please sign in to comment.