test: add go test cases for txn-context-enabled config
#2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PokIsemaine
changed the title
txn_context_enabled configtxn-context-enabled config
PokIsemaine
changed the title
txn-context-enabled configtxn_context_enabled config
PokIsemaine
changed the title
txn_context_enabled configtxn-context-enabled config
mapleFU
approved these changes
Sep 9, 2024
| } | ||
|
|
||
| // / GenerateConfigsMatrix generates all possible combinations of config options | ||
| func GenerateConfigsMatrix(configOptions []ConfigOptions) ([]KvrocksServerConfigs, error) { |
There was a problem hiding this comment.
So this only return false when options is error?
Comment on lines
+63
to
+66
| currentConfigBackup := make(KvrocksServerConfigs, len(currentConfig)) | ||
| for k, v := range currentConfig { | ||
| currentConfigBackup[k] = v | ||
| } |
There was a problem hiding this comment.
Copying this might be heavy weight but lgtm since it's just testing...
|
Retrigger CI, would merge if all ci passed |
|
git-hulk
approved these changes
Sep 10, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2514
I added a config test of
txn-context-enabledto the not particularly time-consuming go test casesAlso, I've noticed that some of the tests have
resp3-enabledrelated tests, which require multiple layers of nesting and branching if combined withtxn-context-enabled.To alleviate this, I tried adding
util. GenerateConfigsMatrixto generate possible config combinations, which you learn about by usingTestGenerateConfigsMatrixinconfig_test.go. At the moment, onlyYesNoconfigs are supported, but I think this will provide some convenience for config-related testing, and we can support more types later if needed