IoTConsensusV2: Introduce IoTConsensusV2 and corresponding mode option #13440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/conf/SystemPropertiesUtils.java
Outdated
Show resolved
Hide resolved
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift
Outdated
Show resolved
Hide resolved
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
Show resolved
Hide resolved
Caideyipi
reviewed
Sep 14, 2024
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/config/PipeConsensusConfig.java
Outdated
Show resolved
Hide resolved
| @@ -154,10 +154,20 @@ data_replication_factor=1 | |||
| # 1. org.apache.iotdb.consensus.simple.SimpleConsensus (The data_replication_factor can only be set to 1) | |||
| # 2. org.apache.iotdb.consensus.iot.IoTConsensus | |||
| # 3. org.apache.iotdb.consensus.ratis.RatisConsensus | |||
| # effectiveMode: first_start | |||
| # 4. org.apache.iotdb.consensus.ratis.IoTConsensusV2 | |||
| # effectiveMode: restart | |||
| # Datatype: string | ||
| data_region_consensus_protocol_class=org.apache.iotdb.consensus.iot.IoTConsensus | ||
|
|
||
| # IoTConsensusV2 mode. | ||
| # This parameter is unmodifiable after ConfigNode starts for the first time. |
There was a problem hiding this comment.
remove this line?
| # These consensus protocol modes are currently supported: | ||
| # 1. batch | ||
| # 2. stream | ||
| # effectiveMode: first_start |
There was a problem hiding this comment.
restart?
BTW, Should we allow some nodes to stream and some nodes to batch? @SteveYurongSu
| @@ -1804,12 +1814,12 @@ schema_region_ratis_periodic_snapshot_interval=86400 | |||
| data_region_ratis_periodic_snapshot_interval=86400 | |||
|
|
|||
| #################### | |||
| ### Fast IoTConsensus Configuration | |||
| ### IoTConsensusV2 Configuration | |||
| #################### | |||
| # Default event buffer size for connector and receiver in pipe consensus | |||
There was a problem hiding this comment.
remove pipeconsensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.