Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] Download JSC header files from remote during compiling #2960

Merged
merged 12 commits into from
Oct 12, 2019
Merged

[Android] Download JSC header files from remote during compiling #2960

merged 12 commits into from
Oct 12, 2019

Conversation

YorkShen
Copy link
Contributor

@YorkShen YorkShen commented Oct 11, 2019 •
edited

  • Download JSC header files from remote during compiling.
  • Delete header files/.so files/legacy source files during ./gradlew clean
  • Update LICENSE.

@YorkShen YorkShen added this to the Weex 0.27 milestone Oct 11, 2019
@weex-bot
Copy link

weex-bot commented Oct 11, 2019 •
edited

Warnings
⚠️ No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️ If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue

Generated by 🚫 dangerJS against 729f6bc

@YorkShen YorkShen changed the title [Android] Downloading JSC header files during Apache Release. [Android] Download JSC header files from remote during compiling Oct 12, 2019
lucky-chen
lucky-chen approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@lucky-chen lucky-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucky-chen lucky-chen merged commit 685ec8a into master Oct 12, 2019
@YorkShen YorkShen deleted the feature/jsc_header branch October 12, 2019 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucky-chen lucky-chen lucky-chen approved these changes

@Darin726 Darin726 Awaiting requested review from Darin726

@gubaojian gubaojian Awaiting requested review from gubaojian

@wqyfavor wqyfavor Awaiting requested review from wqyfavor wqyfavor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Weex 0.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorkShen @weex-bot @lucky-chen