Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

* [Android] Remove shared library from binary of Weex #2940

Merged
merged 6 commits into from
Oct 11, 2019
Merged

* [Android] Remove shared library from binary of Weex #2940

merged 6 commits into from
Oct 11, 2019

Conversation

YorkShen
Copy link
Contributor

@YorkShen YorkShen commented Sep 26, 2019 •
edited

  • Use jsc-android under BSD Licnese to replace LGPL dependency. The jsc-android dependency only exists in compiling time, there is no limited in runtime for users, they could use whatever they like.
  • Remove LGPL files(*.so) in the convenience binary of Weex, which will give users the freedom of choosing JS interpreter at runtime.

@weex-bot
Copy link

weex-bot commented Sep 26, 2019 •
edited

Warnings
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
⚠️ No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️ Current pr not bind the milestone
⚠️ If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue

Generated by 🚫 dangerJS against 335addd

@YorkShen YorkShen force-pushed the feature/remove_sharedLibrary branch 5 times, most recently from ac80d72 to 1c0ea33 Compare September 27, 2019 02:29
@YorkShen YorkShen changed the title * [Android] Remove shared library * [Android] Remove shared library from binary of Weex Sep 27, 2019
@YorkShen
Copy link
Contributor Author

YorkShen commented Sep 27, 2019 •
edited

En...

To my surprise, the URL obejcet in groovy doesn't support redirection, which cause Travis Failure. I will look into it later.

@YorkShen
Copy link
Contributor Author

The URL redireciton is fixed by using to https://github.com/apache/incubator-weex/blob/release/0.26/android/sdk/weex_sdk-0.26.0.aar.

@YorkShen YorkShen added this to the Weex 0.27 milestone Oct 11, 2019
lucky-chen
lucky-chen approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@lucky-chen lucky-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucky-chen lucky-chen merged commit 739e07f into master Oct 11, 2019
@YorkShen YorkShen deleted the feature/remove_sharedLibrary branch October 11, 2019 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucky-chen lucky-chen lucky-chen approved these changes

@Darin726 Darin726 Awaiting requested review from Darin726

@gubaojian gubaojian Awaiting requested review from gubaojian

@wqyfavor wqyfavor Awaiting requested review from wqyfavor wqyfavor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Weex 0.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorkShen @weex-bot @lucky-chen