Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] Add the ability of renaming package by -PapachePackageName=false #2925

Merged
merged 1 commit into from
Sep 20, 2019
Merged

[Android] Add the ability of renaming package by -PapachePackageName=false #2925

merged 1 commit into from
Sep 20, 2019

Conversation

YorkShen
Copy link
Contributor

@YorkShen YorkShen commented Sep 20, 2019 •
edited

  • -PapachePackageName=true, use org.apache.weex as package name.
  • -PapachePackageName=false, use com.taobao.weex as package name.

@weex-bot
Copy link

Warnings
⚠️ No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️ Current pr not bind the milestone
⚠️ If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue
Messages
📖 danger test finished.

Generated by 🚫 dangerJS against b8fbeca

lucky-chen
lucky-chen approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@lucky-chen lucky-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucky-chen lucky-chen merged commit 9b07a12 into apache:master Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucky-chen lucky-chen lucky-chen approved these changes

@Darin726 Darin726 Awaiting requested review from Darin726

@gubaojian gubaojian Awaiting requested review from gubaojian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorkShen @weex-bot @lucky-chen